[Bug 234331] Review Request: linuxdcpp - Direct Connect client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client


https://bugzilla.redhat.com/show_bug.cgi?id=234331


mgarski at post.pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(mgarski at post.pl)  |




------- Additional Comments From mgarski at post.pl  2007-10-11 16:15 EST -------
(In reply to comment #16)
> Bad:
> - License Tag says GPLv2+

Yes it's GPLv2+, because if you look at the source files you will notice:
"either version 2 of the License, or (at your option) any later version."

> - Duplicate BuildRequires: pkgconfig (by gtk2-devel), 
>   glib2-devel (by gtk2-devel), gtk2-devel (by libglade2-devel), 
>   zlib-devel (by openssl-devel)

IMHO it's duplicate but correct see bug #178031 comment #7 (this stuff is
checked by scons).

> - Rpmlint complaints on source rpm:
>  $ rpmlint linuxdcpp-1.0.0-1.fc7.src.rpm
> linuxdcpp.src:25: W: rpm-buildroot-usage %build FAKE_ROOT="$RPM_BUILD_ROOT"

Fixed.

http://mgarski.fedorapeople.org/linuxdcpp-1.0.0-2.fc7.src.rpm
http://mgarski.fedorapeople.org/linuxdcpp.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.