[Bug 328771] Review Request: babl - A dynamic, any to any, pixel format conversion library

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 12 07:37:56 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: babl - A dynamic, any to any, pixel format conversion library


https://bugzilla.redhat.com/show_bug.cgi?id=328771


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr
            Summary|Review Request: babl - A    |Review Request: babl - A
                   |dynamic, any to any, pixel  |dynamic, any to any, pixel
                   |format conversion library   |format conversion library




------- Additional Comments From pertusus at free.fr  2007-10-12 03:37 EST -------
For the url, you should use, such that it is easier to check 
your source:
http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49

and not use a inexistent source url.

Do you intend to add this package to another branch 
than devel?

I propose the following to ship the html docs:

rm -rf __package_docs
mkdir -p __package_docs
cp -pr docs __package_docs
mv __package_docs/docs __package_docs/html
rm -rf __package_docs/html/tools __package_docs/html/.svn
__package_docs/html/graphics/.svn
rm __package_docs/html/Makefile* __package_docs/html/graphics/Makefile*

and add 
%doc __package_docs/html

You could use
make DESTDIR=%{buildroot} install INSTALL='install -p'
to keep timestamps

Suggestion: use
rm %{buildroot}%{_libdir}/*.la
to be noticed when .la files aren't shipped anymore.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list