[Bug 226468] Merge Review: system-config-samba

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-samba


https://bugzilla.redhat.com/show_bug.cgi?id=226468





------- Additional Comments From nphilipp at redhat.com  2007-10-12 04:46 EST -------
(In reply to comment #1)
> Preliminary Review:-
> 
> rpmlint on SRPM and RPM gave me
> -------------------------------------
> system-config-samba.src:17: W: unversioned-explicit-obsoletes redhat-config-samba

fixed

> system-config-samba.src: W: invalid-license GPL

fixed

> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/sambaParser.py
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/sambaUserWin.py
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/sambaBackend.py
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/sambaDefaults.py
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/mainWindow.py
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/basicPreferencesWin.py
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/sambaUserData.py
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/smb.conf.template
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/addUserWin.py
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/shareWindow.py
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/system-config-samba.glade
> system-config-samba.noarch: E: script-without-shebang
> /usr/share/system-config-samba/sambaToken.py

fixed

> system-config-samba.noarch: E: explicit-lib-dependency libuser-python

What's that supposed to mean? (ignored)

> system-config-samba.noarch: W: incoherent-version-in-changelog 1.2.52 1.2.52-1.fc8

fixed

> system-config-samba.noarch: W: invalid-license GPL

idem

> system-config-samba.noarch: W: obsolete-not-provided redhat-config-samba

It doesn't provide "redhat-config-samba" -> ignored

> system-config-samba.noarch: W: conffile-without-noreplace-flag
> /etc/pam.d/system-config-samba
> system-config-samba.noarch: W: conffile-without-noreplace-flag
> /etc/security/console.apps/system-config-samba

fixed

> 
> 
> -------------------------------------------------------
> also,
>   1) packaging guidelines suggests use of make as 
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e

no really benefit in parallel build, but still: fixed

>   2) good to use %defattr(-,root,root,-)

fixed

system-config-samba-1.2.55-1.fc8 with these changes is building right now.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.