[Bug 329291] Review Request: debootstrap - Bootstrap a basic Debian GNU/Linux system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: debootstrap - Bootstrap a basic Debian GNU/Linux system
Alias: debootstrap-review

https://bugzilla.redhat.com/show_bug.cgi?id=329291





------- Additional Comments From lkundrak at redhat.com  2007-10-12 13:54 EST -------
(In reply to comment #4)

> In the debootstrap I packaged there were configs for
> more distros (I guess they are for ubuntu), that would be nice
> to have.

Fair enough. Bumped to latest 1.0.3.

> But what about the comment from Suse:
> # the .deb is used to get the devices tarball as Debian
> # may expect other devices as MAKEDEV generates... 
> 
> Also when I tried that, I got an error saying something along
> 'only root can create special devices'. But apparently this
> is not the case now. Maybe because of the way you invoke it.

I do it in fakeroot, as you might have noticed. I chose it because it is the way
debian does it.

> The files in lib/debootstrap are not object files, libraries, or 
> internal binaries, they are scripts functions, and script 
> 'configurations' and the devices tarball. All these are better 
> in %_datadir. 

Right. Done.

(In reply to comment #5)
> In fact, unless I am wrong the device-std.tar.gz is used in
> debootstrap, the devices.tar.gz is used for debootstrap-udeb.

Right. devices-std is meant to be used when bootstraping debian installations
from within OS, rather than from installer. The collection of devices generated
by our MAKEDEV, is a bit different from what Debian uses, but after playing a
bit with it an comparing results I decided to leave it as it is. Though our one
has more devices and but lacks some, I believe that the the lacking ones weren't
instlalled purposefully, just by coincidence of being in Debian MAKEDEV's "std".
In any case, they don't deny the complete /dev from being populated after the
bootstrap -- the installed system does contain MAKEDEV in any case.

> So for debootstrap you should do 
> make install-allarch DESTDIR=$RPM_BUILD_ROOT

Also right. Fixed.

> It could also be possible to build a debootstrap and a 
> debootstrap-udeb package, but in my opinion they should be 
> named like in debian.

No need for -udeb. We are not a debian installer.

I also turned the package into noarch. I'm not completly sure whether the all of
the devices in the tarball are arch independent, as they are generated by arch
dependent MAKEDEV, but I believe it to have no impact (as ones used during
bootstrap are most likely common for different archs and after bootstrap
populating /dev with more useful content is advisable in any case.). I'll
eventually test this on ppc.

So far tested with etch/i386, sid/i386 and gutsy/i386 and confirmed to work.

Spec URL: http://people.redhat.com/lkundrak/SPECS/debootstrap.spec
SRPM URL:
http://people.redhat.com/lkundrak/mock-results/debootstrap-1.0.3-1.fc8.noarch/debootstrap-1.0.3-1.fc8.src.rpm
Mock results:
http://people.redhat.com/lkundrak/mock-results/debootstrap-1.0.3-1.fc8.noarch/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.