[Bug 326841] Review Request: kcbench-data - Kernel sources to be used by kcbench

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kcbench-data - Kernel sources to be used by kcbench


https://bugzilla.redhat.com/show_bug.cgi?id=326841





------- Additional Comments From fedora at leemhuis.info  2007-10-13 10:58 EST -------
thx for reviewing

(In reply to comment #1)
> Sorry for being so slow with this; I keep running out of time.

np -- I've been using a similar script for years without even actually thinking
about submitting it to Fedora
 
> I do wonder about the necessity of packaging the Documentation directory [...]

I had thought about that as well and first wanted to exclude it, and then
thought "better leave it". I now excluded it again. Should it ever be needed
I'll include it.

> One question I have is where the actual dependencies for compiling the kernel
> source are going to come from.  This package has no dependency on make or the C
> compiler, and it doesn't look like the kcbench package does, either.

Forget that (or better: seems I deleted it again, as I think I added it once)

>  Should
> each of the data packages have dependencies on what they need in order to build?

What's currently in Fedora is sufficient and...

>  (They could have minimum gcc release requirements, for example, although I
> doubt a Fedora release would ever violate them unless gcc 5.9 fails to compile
> 2.6.20 ten years from now.)

...when it stops remains to be seen. Thus I didn't add any versions to the requires.

Added a small readme to this package as well.
---
Spec URL:
http://www.leemhuis.info/files/fedorarpms/SPECS.fdr/kcbench-data.spec

SRPM URL:
http://www.leemhuis.info/files/fedorarpms/SRPMS.fdr/kcbench-data-0.1-2.src.rpm

SRPM DIFF URL:
http://www.leemhuis.info/files/fedorarpms/DIFFS.fdr/kcbench-data.rpmdiff

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.