[Bug 292121] Review Request: boxes - Draw any kind of box around some given text

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boxes - Draw any kind of box around some given text


https://bugzilla.redhat.com/show_bug.cgi?id=292121





------- Additional Comments From jhrozek at redhat.com  2007-10-13 16:37 EST -------
New packages:

http://hrozkovi.cz/boxes.spec
http://hrozkovi.cz/boxes-1.1-3.fc7.src.rpm

I tried to address the issues pointed out in comment #5, hope everything is 
packaged according to the Guidelines now..
> Some minor remarks:
> - There's a full stop missing after the %description.
> - No need to put a '/' before %{_prefix} or similar paths.
> - Default permissions for directories are not set in %defattr (fourth arg).
> - The patch file contains a whitespace change.
The above should be fixed.
> - The patch file is named 'fix_smp_flags' but also comments the strip 
command from the Makefile.
I've renamed the patch and added a comment to the specfile describing what it 
really does. 

After some thinking, I decided that it would be wisest to drop the Emacs 
helper for now. I don't use Emacs myself, so I don't understand half of the 
terms used in the Emacs guidelines and frankly, I'm not all that much willing 
to learn how Emacs and its add-ons work, not to mention lisp. Maintaining 
something you don't use is bad. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.