[Bug 245826] Review Request: pida - A Python IDE written in Python and GTK

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pida - A Python IDE written in Python and GTK


https://bugzilla.redhat.com/show_bug.cgi?id=245826


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-10-14 23:57 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM.
- rpmlint complains follwing messages
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/optionsmanager/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/project/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/commander/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/grepper/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/filemanager/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/statusbar/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/window/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/openwith/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/webbrowser/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/contexts/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/rpc/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/help/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/appcontroller/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/bugreport/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/versioncontrol/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/editor/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/shortcuts/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/sessions/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/buffer/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/notify/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/plugins/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/manhole/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/services/filewatcher/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/editors/vim/service.pida
pida.i386: E: zero-length
/usr/lib/python2.5/site-packages/pida/editors/emacs/service.pida
 But these messages can be ignored here.
+ source files match upstream.
d24bbdc2c07172062cf55dffe58c85f6  PIDA-0.5.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ update-desktop-database and gtk-update-icon-cache scriptlets are used.
+ Desktop file installed correctly.
+ Package pida-0.5.1-3.fc8 ->
   Requires: /usr/bin/env /usr/bin/python emacs gazpacho hicolor-icon-theme
libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.1.3) libcairo.so.2 libdl.so.2
libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0
libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0
libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 python-kiwi rtld(GNU_HASH)
vim-X11
  Provides: moo_stub.so
+ GUI App.
APPROVED.


Anyway, I am approving this review with assumption that you will take case of
comment #32 while importing package in CVS.
I have check this package in rawhide and it worked fine for me on i386.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.