[Bug 226465] Merge Review: system-config-nfs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-nfs


https://bugzilla.redhat.com/show_bug.cgi?id=226465





------- Additional Comments From nphilipp at redhat.com  2007-10-15 05:08 EST -------
(In reply to comment #7)
> Thanks for updates.
> Current CVS package build fine in mock i386 but rpmlint gave me
> system-config-nfs.noarch: E: non-executable-script
> /usr/share/system-config-nfs/exports.py 0644
> This text file contains a shebang or is located in a path dedicated for
> executables, but lacks the executable bits and cannot thus be executed.  If
> the file is meant to be an executable script, add the executable bits,
> otherwise remove the shebang or move the file elsewhere.

removed exports.py (very old test script which should have been removed for a
long time)

> system-config-nfs.noarch: W: obsolete-not-provided redhat-config-nfs
> If a package is obsoleted by a compatible replacement, the obsoleted package
> must also be provided in order to provide clean upgrade paths and not cause
> unnecessary dependency breakage.  If the obsoleting package is not a compatible
> replacement for the old one, leave out the provides.

This is the case.

> Also,
>  Is there any need to use following in SPEC?
>    ExclusiveOS: Linux

Not that I knew. Removed.

(In reply to comment #8)
> I am bit confused whether we really need 
> Requires(post): hicolor-icon-theme
> Requires(postun): hicolor-icon-theme
> 
> because
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
> suggests no such usage of Requires needed.

removed hicolor-icon-theme requirement, calling gtk-update-icon-cache with full path

system-config-nfs-1.3.30-1.fc8 is building with these changes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.