[Bug 226470] Merge Review: system-config-services

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-services


https://bugzilla.redhat.com/show_bug.cgi?id=226470


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-10-16 04:49 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM but Not for RPM.
system-config-services.noarch: W: summary-not-capitalized system-config-services
is an initscript and xinetd configuration utility
system-config-services.noarch: E: description-line-too-long
system-config-services is a utility which allows you to configure which services
=> As maintainer wants to do this after F8 release, its ok to approve with these
messages.
system-config-services.noarch: W: obsolete-not-provided serviceconf
system-config-services.noarch: W: obsolete-not-provided redhat-config-services
=>These messages can be ignored for this package.
+ source files match upstream.
766381ad64cfe423c3821c66dc19e224  system-config-services-0.9.17.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ gtk-update-icon-cache scriptlets are used.
+ Desktop files are handled correctly.
+ package system-config-services-0.9.17-1.fc8 ->
  Provides: config(system-config-services) = 0.9.17-1.fc8
  Requires: /sbin/chkconfig /usr/bin/python config(system-config-services) =
0.9.17-1.fc8 hicolor-icon-theme pygtk2 pygtk2-libglade python >= 2.3.0 rhpl
usermode >= 1.36 usermode-gtk xdg-utils
+ GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.