[Bug 226472] Merge Review: system-config-users

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-users


https://bugzilla.redhat.com/show_bug.cgi?id=226472





------- Additional Comments From panemade at gmail.com  2007-10-16 04:57 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM but Not for RPM.
system-config-users.noarch: W: obsolete-not-provided redhat-config-users
=>These messages can be ignored for this package.
+ source files match upstream.
7219d727a99e5c8388d631509e8118ef  system-config-users-1.2.72.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ gtk-update-icon-cache scriptlets are used.
+ Desktop files are handled correctly.
+ package system-config-users-1.2.72-1.fc8 ->
  Provides: config(system-config-users) = 1.2.72-1.fc8
  Requires: /bin/sh /usr/bin/pgrep /usr/bin/python config(system-config-users) =
1.2.72-1.fc8 cracklib-python hicolor-icon-theme libuser-python >= 0.56 pygtk2
pygtk2-libglade python >= 2.0 rhpl rpm-python usermode >= 1.36 xdg-utils
+ GUI app.

APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.