[Bug 333921] Review Request: xgrav - A simple physics simulation for a large number of particles

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xgrav - A simple physics simulation for a large number of particles


https://bugzilla.redhat.com/show_bug.cgi?id=333921


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr
            Summary|Review Request: xgrav - A   |Review Request: xgrav - A
                   |simple physics simulation   |simple physics simulation
                   |for a large number of       |for a large number of
                   |particles                   |particles




------- Additional Comments From pertusus at free.fr  2007-10-16 08:53 EST -------
Instead of patching the Makefile to add RPM_OPT_FLAGS,
I suggest overwriting LINUX_CFLAGS, like

make LINUX_CFLAGS="-c $RPM_OPT_FLAGS `pkg-config --cflags sdl` -DWITH_ROOTWINDOW"

You could also override LINUX_LDFLAGS with
LINUX_LDFLAGS="$RPM_OPT_FLAGS `pkg-config --libs sdl` -lGL `pkg-config --libs
x11` -lm"

zlib-devel isn't directly used, so if you override the LDFLAGS
as I suggest above you can remove that dependency.

Please add a comment stating where the png file comes
from.

In the .desktop file you don't need to add the .png to
the icon name (it is a suggestion).

Also it would be nice to honor rpm macros in the desktop file
and therefore do something like
sed 's;/usr/share;%_datadir;' %{SOURCE1} > xgrav.desktop
and then run desktop-file-install on xgrav.desktop.

To keep timestamps, you should use install -p in
install -p -m 644 example* %{buildroot}%{_datadir}/xgrav

You should use %{buildroot} or $RPM_BUILD_ROOT but not both.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.