[Bug 330831] Review Request: gbrainy - a brain teaser game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gbrainy - a brain teaser game


https://bugzilla.redhat.com/show_bug.cgi?id=330831


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-10-16 14:53 EST -------
Some random notes for 0.3-1:

* Requires
------------------------------------------------------
Requires:       mono-core >= 1.1.7
Requires:       libgnome >= 2.2
Requires:       gtk-sharp2 >= 2.8
Requires:       cairo >= 1.2
Requires:       intltool
-------------------------------------------------------
  - Why is intltool needed (not for BuildRequires but for Requires)?
  - Other Requires are not needed. rpmbuild automatically checks
    the dependencies of libraries installed in the rpm and also mono related 
    dependencies, then adds them to the Requires of binary rpm.

* Mono related packaging issue
  - Currently mono is available on ppc64, so
    "ExcludeArch: ppc64" is needed
  - Debuginfo rpm is empty. 
    This is expected because gbrainy
    rpm does not contain any ELF binary. In this case,
    you must prevent debuginfo rpm from being created by
    adding "%define debug_package %{nil}" (and also
    adding a comment in spec file why this is needed:
    please check http://fedoraproject.org/wiki/Packaging/Debuginfo )

* SourceURL
  - I recommend to use %{name} and %{version} macro in SourceURL
    because with this you probably need not change SourceURL when
    new version is released.

* perl module BuildRequires
  - must be written by the module names, not by rpm names
    (ref: http://fedoraproject.org/wiki/Packaging/Perl )

    In short, "BuildRequires: perl-XML-Parser" must be
    "BuildRequires: perl(XML::Parser)".

* Some notes in %prep/%build/%install section
  - The following line
--------------------------------------------------------------------
sed 's/\/usr\/\/usr/\/usr/' %{_builddir}/%{name}-%{version}/src/gbrainy > tmp
mv -f tmp %{_builddir}/%{name}-%{version}/src/gbrainy
--------------------------------------------------------------------
    can be
--------------------------------------------------------------------
sed -i -e 's|/usr/usr|%{_prefix}|' src/%{name}
--------------------------------------------------------------------
     * You can use "-i" (in place) option of sed
     * You can choose the separator for sed.
     * The working directory at this stage is %{_builddir}/%{name}-%{version}.


* Timestamps
  - Please use
--------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
--------------------------------------------------------------------
    This will save timestamps on most files to be installed (I guess).
    This method usually works for recent Makefiles.

* GTK+ icon cache
  - Icon cache must be updated for icons under %_datadir/icons/hicolor.
    Please check the section "GTK+ icon cache" of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.