[Bug 226461] Merge Review: system-config-language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-language


https://bugzilla.redhat.com/show_bug.cgi?id=226461





------- Additional Comments From panemade at gmail.com  2007-10-18 02:06 EST -------
rpmlint gave me
--------------------------------------------------------------------------
system-config-language.noarch: W: no-documentation
system-config-language.noarch: W: symlink-should-be-relative
/usr/share/firstboot/modules/language.py
/usr/share/system-config-language/language_gui.py
system-config-language.noarch: E: script-without-shebang
/usr/share/system-config-language/gui_install.py
system-config-language.noarch: E: script-without-shebang
/usr/share/system-config-language/gui_progress.py
system-config-language.noarch: E: script-without-shebang
/usr/share/system-config-language/gui_detailsDialog.py
system-config-language.noarch: E: script-without-shebang
/usr/share/system-config-language/tui_install.py
system-config-language.noarch: E: script-without-shebang
/usr/share/system-config-language/language_tui.py
system-config-language.noarch: E: script-without-shebang
/usr/share/system-config-language/locale-list
system-config-language.noarch: E: script-without-shebang
/usr/share/system-config-language/gui_errors.py
system-config-language.noarch: E: script-without-shebang
/usr/share/system-config-language/lang_dict.py
system-config-language.noarch: W: incoherent-version-in-changelog 1.2.12
1.2.12-1.fc8
system-config-language.noarch: W: invalid-license GPL
system-config-language.noarch: W: obsolete-not-provided redhat-config-language
system-config-language.noarch: W: obsolete-not-provided locale_config
system-config-language.noarch: W: conffile-without-noreplace-flag
/etc/pam.d/system-config-language
system-config-language.noarch: W: conffile-without-noreplace-flag
/etc/security/console.apps/system-config-language
system-config-language.src:12: W: unversioned-explicit-obsoletes
redhat-config-language
system-config-language.src:21: W: prereq-use gtk2 >= 2.6
system-config-language.src:22: W: unversioned-explicit-obsoletes locale_config
system-config-language.src: E: no-cleaning-of-buildroot %install
system-config-language.src: W: invalid-license GPL
----------------------------------------------------------------------------

also,
  1) update buildroot tag as given in
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
  2) packaging guidelines suggests use of make as 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e
  3) missing buildroot cleanup in %install. check
http://fedoraproject.org/wiki/Packaging/Guidelines#head-6c809b2e945ca78ae25d040f250be60f73181ef0
  4) any reason for not using macros in %files section
  5) Any reason for commenting %doc COPYING?
  6) good to use %defattr(-,root,root,-)

Update package. Better to provide new SPEC and SRPM links for this package
before actually committing in CVS.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.