[Bug 309061] Review Request: adanaxisgpl - FPS game in 4 spatial dimensions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: adanaxisgpl - FPS game in 4 spatial dimensions


https://bugzilla.redhat.com/show_bug.cgi?id=309061





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-10-19 04:56 EST -------
For 1.2.3-1:

* Source tarball
  - Tarball in your srpm does not match the tarball downloaded
    from upstream:
-------------------------------------------------------
20015891 2007-10-19 08:24 adanaxisgpl-1.2.3-1.fc7/adanaxisgpl-1.2.3.tar.gz
20015932 2007-10-19 09:32 adanaxisgpl-1.2.3.tar.gz

4a199ac0da9468d6b622af53d2189015  adanaxisgpl-1.2.3-1.fc7/adanaxisgpl-1.2.3.tar.gz
2a0b49cb7c2b13b6272420983279288f  adanaxisgpl-1.2.3.tar.gz
-------------------------------------------------------

* Redundant BuildRequires
  - Still some BuildRequires are redundant.
    autoconf, automake - Please explain why these are needed.
                         This spec file does not call autoconf or automake.
    binutils          <- gcc requires this
    glibc-devel       <- gcc requires this
    libGLU-devel      <- freeglut-devel requires this
    SDL-devel         <- SDL_mixer-devel requires this

* Timestamp
  - To keep timestamps, please use the following
--------------------------------------------------------
make DESTDIR=%{buildroot} INSTALL="install -p" CPPROG="cp -p" install
--------------------------------------------------------
    For recent Makefiles, adding 'INSTALL="install -p"' will usually
    save timestamps on installed files. However as this Makefile
    uses install-sh, 'CPPROG="cp -p"' is also needed.

Then:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.