[Bug 331731] Review Request: ltsp-server-config - LTSP5 server-side configurations and setup scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltsp-server-config - LTSP5 server-side configurations and setup scripts


https://bugzilla.redhat.com/show_bug.cgi?id=331731





------- Additional Comments From pertusus at free.fr  2007-10-19 05:08 EST -------
Jim answered me and I sent a mail on the devel list.

There are comments in 
https://bugzilla.redhat.com/show_bug.cgi?id=331651
that are still not taken into account...

Regarding the %ghost, I think that it is wrong to just have it
%ghost, since if it was modified by the user it should be kept
upon removing the package, with .rpmsave. So at least it 
should be %config(noreplace).

Just a suggestion, but I find %changelogs much more
readable with an empty line between each date.

Also
ltsp-server.noarch: W: incoherent-version-in-changelog 0.9 0-9.fc8

rpmlint finds some issues in init scripts:
ltsp-server.noarch: E: no-status-entry /etc/rc.d/init.d/ltsp-swapfile-delete
ltsp-server.noarch: W: no-reload-entry /etc/rc.d/init.d/ltsp-swapfile-delete
ltsp-server.noarch: E: subsys-not-used /etc/rc.d/init.d/ltsp-swapfile-delete

Also you should add scriptlets as in:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-a6d7a1ed9d77dbb8d4af067378a79b838aebb20a

Unowned directories:
/var/lib/ltsp5/
/etc/ltsp-client/

Also maybe /etc/ltsp-client could be /etc/ltsp5/, or /etc/ltsp and other
config stuff could be in here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.