[Bug 331531] Review Request: ltspswapd - Daemon that uses nbd to provide swap space for LTSP thin clients

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltspswapd - Daemon that uses nbd to provide swap space for LTSP thin clients


https://bugzilla.redhat.com/show_bug.cgi?id=331531





------- Additional Comments From pertusus at free.fr  2007-10-19 05:20 EST -------
I think that it is wrong to require /etc/ltsp.conf. A user
may want to use ltspswapd alone. Therefore, I think that 
%{_sysconfdir}/sysconfig/ltspswapd should still used, but only 
if there is no /etc/ltsp5.conf. And it should be said in a
comment in %{_sysconfdir}/sysconfig/ltspswapd.

The corresponding code in init file would be

# Source ltspswapd configuration.
[ -f /etc/sysconfig/ltspswapd ] && . /etc/sysconfig/ltspswapd
[ -f /etc/ltsp5.conf ] && . /etc/ltsp5.conf

A dot is missing at the end of the %description

a -r or similar for the cvs command is also still missing.

Only a suggestion, but in general the %define are put at
the very beginning of the spec file. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.