[Bug 331631] Review Request: mknbi - Utility for creating network bootable images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images


https://bugzilla.redhat.com/show_bug.cgi?id=331631





------- Additional Comments From pertusus at free.fr  2007-10-19 20:45 EST -------
(In reply to comment #8)

Maybe 
%attr(-,root,root) /usr/lib/mknbi/
could be instead
%{_prefix}/lib/mknbi/


> [builder1 at newcaprica SRPMS]$ rpmlint mknbi-1.4.4-5.fc8.src.rpm
> mknbi.src:30: W: rpm-buildroot-usage %build make BUILD_ROOT="$RPM_BUILD_ROOT"
> PREFIX=%{_prefix}
> 
> Not harmful...

This should be fixed.

Also you could do something along
make BUILD_ROOT="$RPM_BUILD_ROOT" PREFIX=%{_prefix} \
        RPMVERSION="$RPM_PACKAGE_VERSION" INSTALL='install -p' install
to keep timestamps.


(In reply to comment #9)
> Regarding $RPM_OPT_FLAGS, we shouldn't use it here.  This is essentially boot
> loader code, and we want to avoid surprises.  It also isn't helpful to have a
> debuginfo package, because how are you going to debug it?

i don't see why the normal $RPM_OPT_FLAGS shouldn't be used.
For the debuginfo, isn't it possible to use some virtualization
to debug?

I suggest using %defattr(-,root,root,-) instead of %defattr(-,root,root)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.