[Bug 304391] Review Request: pidgin-gfire - xFire protocol plug-in for Pidgin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pidgin-gfire - xFire protocol plug-in for Pidgin


https://bugzilla.redhat.com/show_bug.cgi?id=304391





------- Additional Comments From xavier at bachelot.org  2007-10-20 19:47 EST -------
- package name follows guidelines : OK
- spec file name follows guidelines : OK
- Release: follows guidelines for a pre-release : OK 
- Summary: ends with a dot and is probably too long : NOK
  suggestion : Summary: Pidgin plugin for xfire network
- Source URL is good and tarball match upstream : OK
- License: is correct, is allowed in Fedora and match sources : OK
- Text of license is packaged : OK
- BuildRoot: is correct : OK
- Typos in Description : s/incrimenting/incrementing/
  This package not supported by the official Xfire team : missing 'is' and
missing period.
- Static libs are removed : OK
- Macros are used consistently : OK
- Don't package INSTALL file, it's empty : NOK
- Don't package NEWS file, it's mostly empty and point to CHANGELOG
- BuildRequires: and Requires: are correct : OK
- Spec file is legible : OK 
- Builds fine on i386 : OK
- Rpmlint output will be clean once you've removed the empty INSTALL file and
fixed the Summary:

This is not a fully valid review, as I'm also looking for a sponsor, but I hope
it helps.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.