[Bug 226285] Merge Review: perl-XML-Grove

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-XML-Grove
Alias: perl-XML-Grove

https://bugzilla.redhat.com/show_bug.cgi?id=226285


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-10-22 03:24 EST -------
1)you may like to use disttag 
2)rpmlint only complained ->
perl-XML-Grove.noarch: E: invalid-version 0.46alpha
The version string must not contain the pre, alpha, beta or rc suffixes
because when the final version will be out, you will have to use an Epoch tag
to make the package upgradable. Instead put it in the release tag like
0.alpha8.1.
==> You need to follow solution for this error.

perl-XML-Grove.noarch: W: invalid-license Artistic
==> Use GPL+ or Artistic 

perl-XML-Grove.noarch: E: useless-explicit-provides perl(XML::Grove)
This package provides 2 times the same capacity. It should only provide it
once.
==> In this case I think you need to remove unwanted provides. check
http://fedoraproject.org/wiki/Packaging/Perl

perl-XML-Grove.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 15)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.
==> Use "sed -i -e 's|\t|  |g' perl-XML-Grove"

3) make test is failing in mock build as
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/factory....ok
t/grove......FAILED tests 3-4
        Failed 2/5 tests, 60.00% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/grove.t                  5    2  40.00%  3-4
Failed 1/2 test scripts, 50.00% okay. 2/10 subtests failed, 80.00% okay.
make: *** [test_dynamic] Error 255
+ :
+ exit 0


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.