[Bug 226249] Merge Review: perl-Date-Calc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-Date-Calc


https://bugzilla.redhat.com/show_bug.cgi?id=226249


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-10-22 06:23 EST -------
1)perl as BR is not needed. mock build without it worked successfully.
   remove redundant dependency on perl >= 1:5.6.1
2)you may like to use disttag
3)rpmlint only complained ->
perl-Date-Calc.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.
==>Use "sed -i -e 's|\t|  |g' perl-Date-Calc.spec"

===> I think you can add following to SPEC
chmod 644  examples/*.{pl,cgi} tools/*.pl
after adding that rpmlint mesasges got reduced to 
perl-Date-Calc.i386: W: file-not-utf8 /usr/share/doc/perl-Date-Calc-5.4/EXAMPLES.txt
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

perl-Date-Calc.i386: W: spurious-executable-perm
/usr/share/doc/perl-Date-Calc-5.4/tools/compile.sh
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

perl-Date-Calc.i386: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-Date-Calc-5.4/tools/compile.bat
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

perl-Date-Calc.i386: W: file-not-utf8 /usr/share/doc/perl-Date-Calc-5.4/CREDITS.txt
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).

perl-Date-Calc.i386: E: useless-explicit-provides perl(Date::Calc)
This package provides 2 times the same capacity. It should only provide it
once.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.