[Bug 239247] Review Request: emacs-common-ebib - BibTeX database manage for Emacsen

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 23 03:25:46 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emacs-common-ebib - BibTeX database manage for Emacsen


https://bugzilla.redhat.com/show_bug.cgi?id=239247


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




------- Additional Comments From tibbs at math.uh.edu  2007-10-22 23:25 EST -------
Might as well try to deal with any other pending emacs packages.  Which is just this one, I think.

Some interesting bits:

This:
  head -28 ~/tmp/ebib-1.3.1/ebib.el | sed 's/;;//g' > COPYING
has about zero chance of working.

rpmlint says:
   emacs-common-ebib.noarch: E: zero-length 
   /usr/share/doc/emacs-common-ebib-1.3.1/COPYING
Fallout from the above.

   emacs-common-ebib.noarch: E: description-line-too-long modifying entries),    
   searched, and saved. Obviously, it is also possible to start
This goes to exactly 80 characters; might be nice to wrap at 72.  I don't know what rpmlint will allow before complaining.

   emacs-common-ebib.noarch: W: non-standard-group Applications/Office
   emacs-ebib.noarch: W: non-standard-group Applications/Office
   emacs-ebib-el.noarch: W: non-standard-group Applications/Office
   xemacs-ebib.noarch: W: non-standard-group Applications/Office
   xemacs-ebib-el.noarch: W: non-standard-group Applications/Office
Group is irrelevant these days.

   emacs-ebib.noarch: W: no-documentation
   emacs-ebib-el.noarch: W: no-documentation
   xemacs-ebib.noarch: W: no-documentation
   xemacs-ebib-el.noarch: W: no-documentation
These are OK.

I know there's a bunch of stuff in the emacs packaging guidelines that isn't in this package.  Things like the versioned dependencies on emacs(bin) and xemacs(bin) and the pkgconfig calls to extract that info.  Over time I've lost any emacs expertise I ever had, but the guidelines do have a reasonable explanation of why those dependencies are necessary.  But I guess you should know better than most.  Are they needed in this package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list