[Bug 225863] Merge Review: gsl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gsl


https://bugzilla.redhat.com/show_bug.cgi?id=225863





------- Additional Comments From varekova at redhat.com  2007-10-23 08:00 EST -------
* URL seems to be
http://www.gnu.org/software/gsl/
and source should certainly come from gnu.
-> you are right, changed


* missing dot at the end of %descriptions
-> added

* Why isn't the pkgconfig file distributed????
-> right suggestion - gsl.pc is added

* the gsl-config script created on the fly certainly needs a comment.
And is strange anyway. 

It would be better, in my opinion either
  - to create a wrapper around pkg-config calls that recreates the 
    gsl-config output.
  - or leave gsl-config as is, if not using pkgconfig it is expected
    to have multilib stuff broken.
-> I can't imagine any think it there is not any better way - it is isomorphic
to use gsl.pc or to use the present solution. It is impossible to leave
gsl-config as it is because of that version causes multilib problem and it would
be impossible to install 64 and 32 versions.

* if the code is still useful, instead of
gslcsuffix=`echo "%{_libdir}" | sed s,/usr/,,`
I suggest using %_lib
-> changed, thanks

* .la files are still there
-> removed, thanks

Suggestions:
* remove .gz from install-info snippets

* use %defattr(-,root,root,-) instead of %defattr(-,root,root)
-> added


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.