[Bug 226246] Merge Review: perl-Compress-Zlib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-Compress-Zlib


https://bugzilla.redhat.com/show_bug.cgi?id=226246


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-10-24 00:19 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2eb448ae8ec536f4b6744882f02819d3  Compress-Zlib-2.005.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs 
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/000prereq.....ok
t/01version.....ok
t/03zlib-v1.....ok
t/05examples....ok
t/06gzsetp......ok
t/08encoding....ok
t/14gzopen......ok
t/99pod.........ok
All tests successful.
Files=8, Tests=726,  2 wallclock secs ( 2.15 cusr +  0.31 csys =  2.46 CPU)
+ Package  perl-Compress-Zlib-2.005-3.fc8->
  Provides: perl(Compress::Zlib) = 2.005 perl(Zlib::OldDeflate)
perl(Zlib::OldInflate)
  Requires: perl >= 0:5.004 perl(AutoLoader) perl(Carp)
perl(Compress::Raw::Zlib) >= 2.005 perl(Exporter)
perl(IO::Compress::Base::Common) >= 2.005 perl(IO::Compress::Gzip) >= 2.005
perl(IO::Compress::Gzip::Constants) >= 2.005 perl(IO::Handle)
perl(IO::Uncompress::Gunzip) >= 2.005 perl(Scalar::Util) perl(bytes)
perl(constant) perl(strict) perl(warnings)

APPROVED.


As reviewed package is in CVS, you can CLOSE this review.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.