[Bug 349791] Review Request: PySolFC-cardsets - Various cardsets for PySolFC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PySolFC-cardsets - Various cardsets for PySolFC


https://bugzilla.redhat.com/show_bug.cgi?id=349791





------- Additional Comments From tibbs at math.uh.edu  2007-10-24 01:11 EST -------
Builds OK; rpmlint says:

PySolFC-cardsets.noarch: W: no-documentation
  No problem.

PySolFC-cardsets.noarch: E: script-without-shebang
/usr/share/PySolFC/data/cardset-hannover-court/COPYRIGHT
PySolFC-cardsets.noarch: E: script-without-shebang
/usr/share/PySolFC/data/cardset-hannover-hex/COPYRIGHT
  These are executable for some reason, and probably shouldn't be.  They're the
  only two executable files in the package.

I think the URL: tag should be http://pysolfc.sourceforge.net/

You can get rid of the python_sitelib and debug_package defines at the top of
the spec.  I also don't see the reason for the build dependency on python-devel
when the only thing this package does is copy a directory.

There seems to be a directory ownership problem; nothing seems to own
/usr/share/PySolFC/data.  The base PySolFC package just puts the base cardsets
in /usr/share/PySolFC.

You probably want to change the Summary and %description to mention PySolFC
instead of pysol (and tack a period onto the end of %description while you're in
there).

You can do that thing without using the dist tag if you like.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.