[Bug 282521] Review Request: dblatex - DocBook to LaTeX/ConTeXt Publishing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dblatex - DocBook to LaTeX/ConTeXt Publishing


https://bugzilla.redhat.com/show_bug.cgi?id=282521





------- Additional Comments From pertusus at free.fr  2007-10-24 19:18 EST -------
You should link 
/usr/share/dblatex/xsl
to
/usr/share/sgml/docbook/xsl-stylesheets/dblatex
otherwise nothing works.

Maybe you could obfuscate the email adresses in the 
description, or even remove them and leave only the
names.

To keep the timestamps while doing the required iconv 
magic, you could do

iconv -f iso-8859-1 -t utf-8 $f > $f.utf8 ; touch -r $f $f.utf8 ; mv $f.utf8 $f

I suggest avoid bashisms, and therefore using
mv $file $RPM_BUILD_ROOT%{_datadir}/texmf/tex/latex/dblatex/`basename $file`;

Also protecting end of lines is not needed, instead proper
indentation should help readability.

You don't need the python_sitearch definition.

relevant rpmlint warning
dblatex.src:78: W: macro-in-%changelog _datadir
dblatex.src:80: W: macro-in-%changelog _datadir

The conditional should certainly be
%if 0%{?fedora} < 8

man page is automatically flaged as %doc.

You should certainly own
/etc/dblatex

There are too much in the doc directory, and it is better
to put the files in %doc directly. In my opinion there should
only be

%doc docs/manual.pdf

You should certainly remove the empty directories
/usr/share/dblatex/latex/misc
/usr/share/dblatex/latex/specs
/usr/share/dblatex/latex/style

You need to run texhash post scripts.

COPYRIGHT should be in %doc

Suggestions:

use
%{_mandir}/man1/dblatex.1*
to catch all possible compression, and no compression.

In the .specs file, now that the .sty are in the normal locations,
you can certainly comment out the TexInputs: definition.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.