[Bug 349791] Review Request: PySolFC-cardsets - Various cardsets for PySolFC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PySolFC-cardsets - Various cardsets for PySolFC


https://bugzilla.redhat.com/show_bug.cgi?id=349791





------- Additional Comments From tibbs at math.uh.edu  2007-10-24 22:19 EST -------
I think you meant
http://www.diffingo.com/downloads/diffingo-repo/PySolFC-cardsets-1.1-2.src.rpm
(no ".fc8")

It occurs to me that the reason I couldn't download the source is because the
Source0: URL is incorrect.  I found that
http://downloads.sourceforge.net/pysolfc/PySolFC-Cardsets-1.1.tar.bz2 works fine.

I still don't get why python-devel is needed to build this; I built both with
and without it and the resulting package is the same.

Unfortunately, that package doesn't actually seem to do anything when I install
it.  Pysol shows the same cardsets whether this package is installed or not. 
However, I moved everything from /usr/share/PySolFC/data one directory up and
the cardsets were found.  However, there are some directories both in this
package and in the base PySolFC package that contain the same data:

cardset-2000
cardset-crystal-mahjongg
cardset-dashavatara-ganjifa
cardset-dondorf
cardset-gnome-mahjongg-1
cardset-hexadeck
cardset-kintengu
cardset-matrix
cardset-mughal-ganjifa
cardset-oxymoron
cardset-standard
cardset-tuxedo
cardset-vienna-2k

I'm not sure there's any point in packaging them.

So I guess either PySolFC needs a patch to look in the "data" directory for
cardsets or this package needs to install into %{_datadir}/PySolFC

Oh, yeah, and %description lacks a trailing period.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.