[Bug 225863] Merge Review: gsl

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 25 17:04:09 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gsl


https://bugzilla.redhat.com/show_bug.cgi?id=225863





------- Additional Comments From pertusus at free.fr  2007-10-25 13:04 EST -------
You should either have 
%{_datadir}/aclocal

or
%{_datadir}/aclocal/*
%dir %{_datadir}/aclocal

Thefollowing is not needed
rm -rf $RPM_BUILD_ROOT%{_sysconfdir}

And why do you remove the man pages?

I suggest replacing
rm -rf $RPM_BUILD_ROOT%{_libdir}/*.la
with
rm $RPM_BUILD_ROOT%{_libdir}/*.la

Only a suggestion, to keep the THANKS file timestamp, you can do
touch -r THANKS THANKS.aux
before mv.

Also it should be better to remove the .gz from install-info 
scriptlets since install-info can detect itself if .gz is needed. 
This is not a blocker, but I can't see why you shouldn't do it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list