[Bug 351531] Review Request: ristretto - Image-viewer for the Xfce desktop environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ristretto - Image-viewer for the Xfce desktop environment


https://bugzilla.redhat.com/show_bug.cgi?id=351531





------- Additional Comments From fedora at christoph-wickert.de  2007-10-25 19:24 EST -------
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > 
> > Sorry, this was a last minute change. I had "User Interface/Desktops", but
> > changed it to "Amusements/Graphics" in the spec.
> 
> I am not sure that it is right. I would only put image editors in 
> that Group. Not a big deal.

Well, there seems to be no common usage:
$ rpm -qi eog f-spot gthumb gimp mirage | grep Group
Group       : User Interface/Desktops       Source RPM: eog-2.18.2-2.fc7.src.rpm
Group       : Applications/Multimedia       Source RPM: f-spot-0.3.5-2.fc7.src.rpm
Group       : User Interface/X              Source RPM: gthumb-2.10.6-1.fc7.src.rpm
Group       : Applications/Multimedia       Source RPM: gimp-2.2.17-1.fc7.src.rpm
Group       : Amusements/Graphics           Source RPM: mirage-0.9-1.fc7.src.rpm

I agree we could use User Interface/Desktops

> 
> > > It should certainly be cleaner to have buildrequires
> > > libxfce4util-devel >= 4.4.0
> > 
> > Oops. I think I'll remove libxfce4util since it is redundant anyway,
> > libxfce4util-devel is pulled in by Thunar-devel.
> 
> (by exo-devel) but without version constraints. So it may make
> sense to keep the versioned BR here.

+1

> 
> i tried 
> $ ristretto ristretto-screenshot.png
> 
> and still a black main area. And even when i click on it
> nothing happens.

Ok, I'll test on a minimal system, there seems to be a missing requirement.

> 
> > but ristretto doesn't handle svg or eps atm.
> 
> Ok. The mini images are shown, though.

Maybe these are cached thumbnails (pngs) that are created by a running Thunar or
nautilus? Or it is indeed a bug in ristretto, the program is still in an early
state. Anyway, I tried all the other filetypes you suggested and they all work
except svg and eps.

>  
> > (In reply to comment #3)
> > > It may be important to say that I am in fluxbox.
> > 
> > Doesn't matter as long as you have Thunar installed (Thunar and ristretto are
> > sharing their thumbnail cache). Ristretto requires libthunar-vfs-1.so.2, so
> > Thunar will be installed automagically.
> 
> Indeed, but I experienced sometimes different behavior when not in 
> a desktop like gnome/kde/xfce, like
> http://thunar.xfce.org/pwiki/documentation/faq
> question
> Why does Thunar display the fallback icon for all files and folders?

This seems to be an error in the underlying thunar-vfs layer. Ristretto uses
thunar_vfs_mime_info_get_media to determine the file type, if it returns NULL,
no image is shown. shared-mime-data should be installed with Thunar, so I have
no idea what could be wrong here.

(In reply to comment #6)
> I have the same issue in xfce.

You mean, you have no icons in Thunar even in Xfce?
 
> i also get warnings:
> (ristretto:22815): GLib-GObject-CRITICAL **: g_value_get_pointer: assertion
> `G_VALUE_HOLDS_POINTER (value)' failed
> 
> (ristretto:22819): GLib-GObject-CRITICAL **: g_value_get_pointer: assertion
> `G_VALUE_HOLDS_POINTER (value)' failed
> 

Sorry, I don't see anything like that here in my F7 machine. When do these
errors appear?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.