[Bug 351251] Review Request: Func - Fedora Unified Network Controller

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Func - Fedora Unified Network Controller


https://bugzilla.redhat.com/show_bug.cgi?id=351251





------- Additional Comments From tla at rasmil.dk  2007-10-26 07:13 EST -------
MUST:
* package is named appropriately
* it is legal for Fedora to distribute this
X license field matches the actual license.
  see earlier comment
* license is open source-compatible.
* specfile name matches %{name}
? verify source and patches (md5sum matches upstream, know what the patches do)
    No upstream tarball to match, SRPM is upstream source.
* summary and description fine
* correct buildroot
* %{?dist} is used
X license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine 
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* License used and not Copyright 
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86
X BuildRequires are proper
  See earlier comment.
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* no libraries
* no rpath
* not a GUI app
* no -devel sub-package necessary
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* no locale data
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
X file permissions fine
  See earlier comments.
X %defattrs present ( %defattr(-, root, root, -))
* %clean present
* %doc files do not affect runtime


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.