[Bug 351251] Review Request: Func - Fedora Unified Network Controller

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Func - Fedora Unified Network Controller


https://bugzilla.redhat.com/show_bug.cgi?id=351251





------- Additional Comments From mdehaan at redhat.com  2007-10-26 13:10 EST -------
Responding to the 3rd part:

MUST:

X license field matches the actual license.

* This has been corrected, updated URLs coming shortly

? verify source and patches (md5sum matches upstream, know what the patches do)
    No upstream tarball to match, SRPM is upstream source.

* Snapshot tarball can be uploaded, one of the developers is the upstream
packager, see also: git

X license text included in package and marked with %doc

* Has been added

X BuildRequires are proper

* Fixed.

X file permissions fine
  See earlier comments.

* I'm in disagreement with the need for module (non-script) code to be chmod+x,
if you can point me at packaging guidelines that indicate this is a requirement
I'll address it.

X %defattrs present ( %defattr(-, root, root, -))

* Adding...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.