[Bug 346121] Review Request: malaga - Programming language for modelling of language-dependent grammatical information

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: malaga - Programming language for modelling of language-dependent grammatical information


https://bugzilla.redhat.com/show_bug.cgi?id=346121





------- Additional Comments From vpivaini at cs.helsinki.fi  2007-10-26 18:53 EST -------
I've tried to fix most issues you pointed out.

New spec: http://vpv.fedorapeople.org/packages/malaga.spec
New SRPM: http://vpv.fedorapeople.org/packages/malaga-7.11-0.3.fc7.src.rpm

(In reply to comment #3)

> $ sed -i.strip -e 's| -s | |' Makefile.in

Done.
 
>   - Actually remove this static archive before %install finishes
>    (by "rm -f", for example) and remove this entry from %files.

Done.


>     Please make build procedure more verbose. To do so, please remove
>     @ (at-mark)s which suppress build process output from Makefile.in.

Done.
 
>   - Also, it is preferred that you make libtool output more verbose

Done.

> * linkage against libmalaga.so
>   - The installed binaries in malaga don't use libmalaga.so (
>     is not linked against libmalaga.so).

NOT done yet, mostly because of lack of time in the recent couple of days and
also lack of knowledge. I assume I'd have to patch Makefile.in heavily so that
the binaries would actually use libmalaga.so? Also, is this really necessary,
the binaries would then differ from those that are built from pristine upstream
sources? If this is needed, I'll try to study about it during the next few days.

>   "Requires: gtk2" is not needed.

Fixed.


> INSTALL="install -p"

Added.

>   - Permission of libmalaga.so must be 0755, not 0644
>   ! Don't use %attr. Change the permission of file before %install
>     section ends so that this libraries can be stripped by
>     rpmbuild.

Currently I've done this so that all libmalaga.so* files have permissions 0755.
Though it seems to me that the library (only one, the rest are actually symbolic
links) does get stripped by rpmbuild even if it is 0644.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.