[Bug 226264] Merge Review: perl-IO-Socket-SSL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-IO-Socket-SSL


https://bugzilla.redhat.com/show_bug.cgi?id=226264


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-10-26 21:59 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0f6e80c15341094df16828a25dbaeeaa  IO-Socket-SSL-1.12.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
<skipped> long output here
All tests successful.
Files=13, Tests=185, 34 wallclock secs ( 1.72 cusr +  0.36 csys =  2.08 CPU)
+ Package perl-IO-Socket-SSL-1.12-1.fc8 ->
 Provides: perl(IO::Socket::SSL) = 1.12 perl(IO::Socket::SSL::SSL_Context)
perl(IO::Socket::SSL::SSL_HANDLE) perl(IO::Socket::SSL::Session_Cache)
 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Errno) perl(Exporter)
perl(IO::Socket) perl(Net::SSLeay) >= 1.21 perl(constant) perl(strict) perl(vars)

 APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.