[Bug 226265] Merge Review: perl-IO-String
bugzilla at redhat.com
bugzilla at redhat.com
Sat Oct 27 02:04:43 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-IO-String
https://bugzilla.redhat.com/show_bug.cgi?id=226265
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade at gmail.com 2007-10-26 22:04 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
250e5424f290299fc3d6b5d1e9da3835 IO-String-1.08.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/close.......ok
t/para........ok
t/read........ok
t/seek........ok
t/truncate....ok
t/write.......ok
All tests successful.
Files=6, Tests=43, 0 wallclock secs ( 0.09 cusr + 0.04 csys = 0.13 CPU)
+ Package perl-IO-String-1.08-3.fc8 ->
Provides: perl(IO::String) = 1.08Requires: perl >= 0:5.005_03
perl(:MODULE_COMPAT_5.8.8) perl(Symbol) perl(strict) perl(vars)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list