[Bug 354101] Review Request: compizconfig-backend-kconfig - kconfig backend for compizconfig

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compizconfig-backend-kconfig - kconfig backend for compizconfig


https://bugzilla.redhat.com/show_bug.cgi?id=354101


s.adam at diffingo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From s.adam at diffingo.com  2007-10-27 01:03 EST -------
Answering the LGPL question, if that code is not being used in the binaries, I
don't see a reason to include it but just to be safe keep it in there. Just fix
that upon import.

+ source files match upstream: d45c21297d0edfe25d41ffa1999ad5b7085b23d5
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. GPL License text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
- rpmlint is silent.
  compizconfig-backend-kconfig.i386: W: summary-not-capitalized kconfig backend
for compizconfig
This is safe to ignore, kconfig shouldn't be capitalized.
+ final provides and requires are sane:
  libkconfig.so  
  compizconfig-backend-kconfig = 0.6.0-1.fc8
+ no shared libraries are added to the regular linker search paths.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.