[Bug 351251] Review Request: Func - Fedora Unified Network Controller

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Func - Fedora Unified Network Controller


https://bugzilla.redhat.com/show_bug.cgi?id=351251


tla at rasmil.dk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tla at rasmil.dk  2007-10-28 06:13 EST -------
* license field matches the actual license.
* license text included in package and marked with %doc
* BuildRequires are proper
* file permissions fine
  python site-lib modules is not scripts, so no need to be +x
* %defattrs present ( %defattr(-, root, root, -))
* verify the final provides and requires of the binary RPMs
	$ rpm -q -R -p rpmbuild/RPMS/noarch/func-0.13-3.fc8.noarch.rpm 
	/bin/sh  
	/bin/sh  
	/bin/sh  
	/usr/bin/python  
	config(func) = 0.13-3.fc8
	pyOpenSSL  
	python >= 2.3
	python(abi) = 2.5
	rpmlib(CompressedFileNames) <= 3.0.4-1
	rpmlib(PartialHardlinkSets) <= 4.0.4-1
	rpmlib(PayloadFilesHavePrefix) <= 4.0-1

    $  rpm -q --provides -p rpmbuild/RPMS/noarch/func-0.13-3.fc8.noarch.rpm 
	config(func) = 0.13-3.fc8
	func = 0.13-3.fc8


? run rpmlint on the binary RPMs
func.noarch: W: incoherent-version-in-changelog 0.0.13-3 0.13-3.fc8
this is because %%SOURCE1 contains 0.13.3 & changelog entries contains 0.0.13-3
as version
func.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/func/*.py
python site-lib modules is not scripts, so no need to be +x
could be made silenced by chmod +x *.py for all *.py files in git.


SHOULD:
* package should include license text in the package and mark it with %doc
* package should build on i386
? package should build in mock
 - I haven't tried, but I don't think it'll be a problem

The Changelog entries should be fixed to have the right versions, feel free to
change the permissions on the *.py files if you like.
but nothing blocking.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.