[Bug 331631] Review Request: mknbi - Utility for creating network bootable images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images


https://bugzilla.redhat.com/show_bug.cgi?id=331631





------- Additional Comments From pertusus at free.fr  2007-10-29 11:56 EST -------
A Vendor tag crept in.

I spotted a license issue:
md5.c has only this license information:
 * This implementation is copyright 1997 by M. Gutschke.

This man seems to be the first etherboot maintainer, so it
is likely not to be very problematic, but still.

Otherwise it seems to be GPLv2+ (some file don't have any license, 
not a big deal, may be worth reporting upstream).


Another issue is that the Source is wrong.

mknbi.html should certainly be in %doc


In general it is better to put perl noarch internal modules in 
%_datadir. And mknbi itself should certainly be in %_bindir 
directly. However, in the case of mknbi, it is certainly too much
work and divergence from upstream to put everything at the right 
place.

Therefore, all the rpmlint warnings are ignorable:
mknbi.src:46: E: hardcoded-library-path in %{_prefix}/lib/mknbi/
mknbi.i386: E: no-binary
mknbi.i386: E: only-non-binary-in-usr-lib
mknbi-debuginfo.i386: E: empty-debuginfo-package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.