[Bug 256341] Review Request: micq - Text/line based ICQ client with many features

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: micq - Text/line based ICQ client with many features


https://bugzilla.redhat.com/show_bug.cgi?id=256341





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-05 12:15 EST -------
Well, lookingly much better!!

For 0.5.4.2-2:

A. Build issue:
1. glibc "open" issue:
  - This time, rebuild for 0.5.4.2-2 fails:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=148606
    This is rawhide glibc (2.6.90) "open(2)" change (related
    discussion here)
    http://www.redhat.com/archives/fedora-maintainers/2007-August/msg00265.html

    The attached patch should solve this problem.

    Note: the reason -1 did not fail is because -1 did not
    pass "-Wp,-D_FORTIFY_SOURCE=2" correctly.

2. Missing BuildRequires
   - And even after my patch is applied, the build still fails:
     http://koji.fedoraproject.org/koji/taskinfo?taskID=148844

     /usr/bin/enconv is in enca package and at least
     "BuildRequires: enca" is needed.

B. Then:
* Description stage
--------------------------------------------------------
Authors: Matthew D. Smith (deceased)
         Rüdiger Kuhlmann <info at ruediger-kuhlmann.de>
--------------------------------------------------------
  - This description is not needed. "AUTHORS" document is enough.

* Encoding
  - Still some man files are in diffferent encodings.
--------------------------------------------------------
micq.i386: W: file-not-utf8 /usr/share/man/it/man1/micq.1.gz
micq.i386: W: file-not-utf8 /usr/share/man/pt_BR/man5/micqrc.5.gz
micq.i386: W: file-not-utf8 /usr/share/man/pt_BR/man1/micq.1.gz
micq.i386: W: file-not-utf8 /usr/share/man/pt_BR/man7/micq.7.gz
--------------------------------------------------------

* Timestamps
  - This package installs many text files (and so on) and
    keeping timestamps on those files are preferable.
    The following will keep them.
----------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
----------------------------------------------------------

Then, as this is a "sponsor needed" ticket:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.