[Bug 201061] Review Request: iserverd - Groupware ICQ server clone

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iserverd - Groupware ICQ server clone


https://bugzilla.redhat.com/show_bug.cgi?id=201061





------- Additional Comments From tibbs at math.uh.edu  2007-09-05 23:21 EST -------
OK, this does indeed build fine.  rpmlint spews a tonne of messages, but many of
them are non-standard-uid or non-standard-gid errors, which are acceptable in
this case as the daemon runs under a special user.  What remains:

E: iserverd non-readable /etc/iserverd/iserv.conf 0600
E: iserverd non-readable /etc/iserverd/v7_proto.conf 0600
E: iserverd non-readable /etc/iserverd/actions.conf 0600
E: iserverd non-readable /etc/iserverd/v3_proto.conf 0600
E: iserverd non-readable /etc/iserverd/v5_proto.conf 0600
E: iserverd non-readable /etc/iserverd/aim_proto.conf 0600
  Obviously these are protected against reads for security reasons.

E: iserverd executable-marked-as-config-file /etc/iserverd/iserverd.sh
E: iserverd executable-marked-as-config-file /etc/iserverd/db/icquser
E: iserverd executable-marked-as-config-file /etc/iserverd/iserverd.sh.asp
  I'm not sure what these are.  Shell scripts can be config files 
  (like /etc/rc.local) so it's possible that this is OK.

E: iserverd non-standard-dir-perm /var/run/iserverd 0770
  This should be OK.

W: iserverd file-not-utf8 /usr/share/doc/iserverd-2.5.5/isdwm-1.4.1.tar.gz
  This is obviously bogus; tarballs don't have encodings.

E: iserverd non-readable /usr/bin/db_manage.sh 0550
E: iserverd non-standard-executable-perm /usr/bin/db_manage.sh 0550
E: iserverd non-standard-executable-perm /usr/bin/convert_db.sh 0550
  I'm not sure about these; what's are they used for?  Should they be in
  /usr/libexec instead?

W: iserverd service-default-enabled /etc/rc.d/init.d/iserverd
  This shouldn't be enabled by default, but I note that you chkconfig it off in 
  %post.  I don't think you want to do that as then updates will disable the 
  server.  Better to patch the initscript if necessary.

E: iserverd-debuginfo empty-debuginfo-package
  This is bad, and frankly I don't see what's causing it.  It looks like 
  everything's being compiled with the proper compiler flags; unfortunately I 
  simply don't know enough about find-debuginfo to comprehend why it doesn't 
  find anything.

The %preun and %postun scripts are weird.    You should add the proper
dependencies on /sbin/service so you can assume it exists, and there shouldn't
be any reason not to unconditionally stop the daemon.  I'm not really sure if it
matters but you might want to stop it before calling chkconfig --del.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.