[Bug 251020] Review Request: libflaim - Flaim Database Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libflaim - Flaim Database Engine


https://bugzilla.redhat.com/show_bug.cgi?id=251020





------- Additional Comments From snecklifter at gmail.com  2007-09-06 10:55 EST -------
Hi Till,

Thanks for assigning yourself to this.

(In reply to comment #3)
> The release should be an integer, imho it is in the Naming Guidelines
> (http://fedoraproject.org/wiki/Packaging/NamingGuidelines)
> 
> So change
> Release:	9.2%{?dist}
> to
> Release:	10%{?dist}
> 
> You can later use
> Release:	10%{?dist}.1
> If you need to increment only in one Fedora Collection that is not Rawhide.
> 
> Source0 is not valid (anymore):
> $ curl -I
>
http://forgeftp.novell.com/flaim/development/flaim/downloads/source/libflaim-4.9.1046.tar.gz
> HTTP/1.1 404 Not Found
> 
> According to the URL in the spec file the latest tarball is:
libflaim-4.9.989.tar.gz
> 
> Is this older version intentional?

The version being built is newer, essentially a subversion checkout therefore I
have made the necessary changes to reflect this.

> The buildroot is not ok, see
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
> 
> You should use %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) or
> some other example from the wiki.

Okay, done.

> Please use rm -rf %{buildroot} instead of rm -Rf %{buildroot}

Okay, done.

> Did you build your packages with mock? When I build it and run rpmlint on the
> rpms, I get:
> $ rpmlint libflaim-*
> W: libflaim unstripped-binary-or-object /usr/lib/libflaim.so.5.2
> E: libflaim-debuginfo empty-debuginfo-package
> W: libflaim-devel no-documentation
> 
> The third warning can be ignored. The build.log shows:
> ldconfig /var/tmp/libflaim-4.9.1046-build/usr/lib
> Installation complete.
> + /usr/lib/rpm/find-debuginfo.sh /builddir/build/BUILD/libflaim-4.9.1046
> 0 blocks
> find: /var/tmp/libflaim-4.9.1046-build/usr/lib/debug: No such file or directory
> 
> But I do not know, why.

This was because the shared object was not installed executable - I have
attached a small patch to resolve this and should hopefully get this upstream
quickly.

Updated RPMS as usual at:

http://snecker.fedorapeople.org/libflaim/

Regards
Chris

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.