[Bug 250924] Review Request: flashrom - Simple program for reading/writing BIOS chips content

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: flashrom - Simple program for reading/writing BIOS chips content


https://bugzilla.redhat.com/show_bug.cgi?id=250924





------- Additional Comments From lemenkov at gmail.com  2007-09-06 11:01 EST -------
(In reply to comment #2)
> This seems to be a pre release snaphsot, so the release should start with 0.
> Also you can use 0 for the Version instead of 0.0. So here is my proposal:
> Version: 0
> Release: 0.1.<date>svn2744%{?dist}
> You should also include the date of the checkout...

Done.

> # svn -r 2744 co svn://linuxbios.org/repos/trunk/util/flashrom flashrom
> # rm -rf flashrom/.svn
> you can use svn export instead of co to avoid the creation of the .svn directory.

Applied, thanks. 
Until now I never heard about such option :)

> You should use
> install -D -p -m644 %{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1/%{name}.1
> to install the manpage (-p is added here) to preserve the timestamp.

Done.

http://peter.fedorapeople.org/flashrom.spec
http://peter.fedorapeople.org/flashrom-0-0.1.20070830svn2753.fc7.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.