[Bug 275211] Review Request: php-channel-phpdb - Adds phpdb channel to PEAR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-channel-phpdb - Adds phpdb channel to PEAR


https://bugzilla.redhat.com/show_bug.cgi?id=275211


fedora at famillecollet.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com




------- Additional Comments From fedora at famillecollet.com  2007-09-08 01:22 EST -------
NOT A FORMAL REVIEW (i'm not a sponsor)

* no source files
* package meets naming and packaging guidelines (no special guideline for channels).
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible (LGPLv2).
* BuildRequires are proper.
* %clean is present.
* package builds in mock (F7 - x86_64).
* package installs properly
* rpmlint :
W: php-channel-phpdb no-documentation
* final provides are sane:
php-channel(pear.phpdb.org) = 1.0.0-3.fc8
php-channel-phpdb = 1.0.0-3.fc8
* %check is not present; no test suite provide.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear channel..)
* no documentation 

No version for the .xml file, but i think using 1.0.0 is OK.
No License but LGPLv2 seems OK as is the license of the package provided on this
channel (could be "public domain").

Should : as the version has no meaning, you probably can ommit it in the virtual
provides : php-channel(pear.phpdb.org)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.