[Bug 283461] Review Request: qpxtool - CD/DVD Quality check tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qpxtool - CD/DVD Quality check tool


https://bugzilla.redhat.com/show_bug.cgi?id=283461





------- Additional Comments From adel.gadllah at gmail.com  2007-09-09 03:18 EST -------
(In reply to comment #1)
> Use:
> Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2
> See:
>
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2

ok

> 
> for -devel subpackge:
> Requires: %{name} = %{version}
> should be
> Requires: %{name} = %{version}-%{release}

ok

> 
> %files devel is missing a %defattr(-,root,root,-)

ok

> 
> the cp invocations should be used with "-p" to preserve the timestamp.
> 
> 
> The Makefile also defines INCDIR (%{_includedir}), which you do not adjust
with sed.

ok

> 
> the manpage is not installed with a preserved timestamp, missing "-p" in the
> install invocation in man/Makefile (line 10), maybe upstream would change this.

ok fixed with a small patch for now.

> 
> In case you did not know:
> you should be able to use make install PREFIX=%{_prefix} LIBDIR=%{_libdir} ...
> instead of the sed magic. 

I know but this would be a long "make line" so I preferd doing it this way.

> Also you can use all sed expressions at once:
> sed -i -e 's!/usr/local!%{_prefix}!g' \
>  -e 's!\$(PREFIX)/bin!%{_sbindir}!g' \
>  -e 's!\$(PREFIX)/lib!%{_libdir}!g' \
>  -e 's!\$(PREFIX)/man!%{_mandir}!g' Makefile

same here I think that this is easier to read

New fixed package:

http://tgmweb.at/gadllah/qpxtool.spec
http://tgmweb.at/gadllah/qpxtool-0.6.1-2.fc7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.