[Bug 283571] Review Request: homebank - Free easy personal accounting for all
bugzilla at redhat.com
bugzilla at redhat.com
Mon Sep 10 19:12:10 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: homebank - Free easy personal accounting for all
https://bugzilla.redhat.com/show_bug.cgi?id=283571
lxtnow at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lxtnow at gmail.com
------- Additional Comments From lxtnow at gmail.com 2007-09-10 15:12 EST -------
Some comments 'bout release *-3.5-2:
# Desktop file
Category "Application" is still present and must be remove.
Use "--remove-category" flag to do so.
MimeType is missing from desktop entry.
this sourcetarball is shipped with an desktop file, why add anorher one ?
It's more appropriate to fix upstream shipped files which's present instead of
add another one if necessary.
# Timstamps
timestamps should be set/kept on all installed images,icons and docs files and
currently they aren't.
Use "INSTALL='install -p'" flag with "make install" to do so.
# Requires
Require pango is redundant.
Already set by rpmbuild.
# desktop file icon.
Also shipped with this source, why add another one ?
# Documentations
About _datadir/%{name}/help ... seem to be a bit large as doc.
I don't think it's mandatory that it be split into a -doc subpackage,
But you should think about this.
Also, this directory should be marked as doc (including doc/TODO file)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list