[Bug 285561] Review Request: wqy-unibit-fonts - a dual-width bitmap font for maximum unicode coverage

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wqy-unibit-fonts - a dual-width bitmap font for maximum unicode coverage


https://bugzilla.redhat.com/show_bug.cgi?id=285561


petersen at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: wqy-unibit -|Review Request: wqy-unibit-
                   |a dual-width bitmap font for|fonts - a dual-width bitmap
                   |maximum unicode coverage    |font for maximum unicode
                   |                            |coverage




------- Additional Comments From petersen at redhat.com  2007-09-11 02:25 EST -------
(In reply to comment #3)
> I changed the package name to wqy-unibit-fonts, updated the spec file with
> F8-style commands, and bumped the version to 1.0.0-2.

Thanks for the update. :)

> rpmlint complained about the symbol link, however I think those commands were
> recommended ones, so, I left as is.

wqy-unibit-fonts.noarch: W: file-not-utf8
/usr/share/doc/wqy-unibit-fonts-1.0.0/README

This would should be fixed IMHO.  You could use iconv to do this
if you want to keep the upstream encoding.

wqy-unibit-fonts.noarch: W: symlink-should-be-relative
/etc/X11/fontpath.d/wqy-unibit-fonts/wqy-unibit
/usr/share/fonts/wenquanyi/wqy-unibit

Right this has been waived in other fonts packages,
though IMHO it would not hurt to fix this too,
but I do not take it as a blocker. :)

> do you suggest dropping fontconfig from Requires? I am worrying that we have
> to remove the fc-cache lines from %post/%postun as well, and I don't know if
> fontconfig will see this font.

No, just the calls to fc-cache should be conditionalized to check that
fc-cache is available that is all.

See the scriplets in the fonts section:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-4863fc4c93cec14292719d8901d83f5d90c3e477

Most installs normally have fontconfig anyway so it is not such
a serious problem I think, but some server configurations might not say.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.