[Bug 276961] Review Request: straw - Desktop news aggregator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: straw - Desktop news aggregator


https://bugzilla.redhat.com/show_bug.cgi?id=276961





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-17 09:00 EST -------
For 0.27-6:

* Requires:
  - Again recheck python related dependency.
    you can try the result
-------------------------------------------------------------
$ LANG=C grep -h 'import ' `rpm -ql straw | grep -v /usr/share/doc` | grep -v
Binary | sed -e 's|^[ \t][ \t]*||' | sort | uniq
-------------------------------------------------------------
    For me it seems
    - libxml2-python, pyorbit are not needed
    - "gtk2 > 2.4", libglade2 are redundant
    - pygtk2-devel must be removed
    + pygtk2-libglade is needed (PreferencesDialog.py requires)
      This will also install pygtk2
    + gnome-python2-libegg is needed (Tray.py requires)
    + gnome-python2-gconf is needed (Config.py requires)

    I attach my check list for python related dependency of
    straw. Please check if it is correct.

* Conflicts
  - Well, would you readd "Conflicts: python-adns" until bug 292821
    is solved?
    * Please add the comment in the spec file like
      "Current python-adns makes double free problem (bug 292821)"

* %pre
  - Please write %pre section after %install section
  - And again fix "[NAME]" to the real gconf file name.

Then:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.