[Bug 254056] Review Request: e16 - The Enlightenment window manager, DR16

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: e16 -  The Enlightenment window manager, DR16


https://bugzilla.redhat.com/show_bug.cgi?id=254056





------- Additional Comments From terjeros at phys.ntnu.no  2007-09-17 12:48 EST -------
> 1. Some of the source files appear to be GPLv2+

GPLv2+ added to license.

> In addition there is a copy of the Bitsteam Vera Fonts with their own license
> inside the "winter.etheme" tar.gz thats in the e16 tar.gz. Can that be made
> somehow to use the already existing Vera package?

Removed ttfonts dir, created a symlink and added bitstream-vera 
to req, seems to work.

 
> I will have spot check it over...

Ok, thanks.


> 2. Some possible missing BuildRequires:

Tried to add some X related devel packages, better now?
 
> 3. rpmlint says:
> 
> e16.i386: E: zero-length /usr/share/e16/themes/winter/slideouts/slideouts.cfg
> e16.i386: E: zero-length /usr/share/e16/themes/winter/buttons/buttons.cfg
> 
> Not sure if those can be removed, or if they are needed by that theme...

Tried that, not a crash, but a freeze, better leave these.
 
> e16.i386: E: invalid-soname /usr/lib/libe16_hack.so libe16_hack.so
> 
> Does that so file need to be in /usr/lib?

Don't know, however e16 seems to be happy without this lib, maybe
needed by the epplets?
 
> e16.i386: W: file-not-utf8 /usr/share/doc/e16-0.16.8.9/ChangeLog
> e16.i386: W: file-not-utf8 /usr/share/doc/e16-0.16.8.9/AUTHORS
>
> Might run 'iconv' on those?

Fixed.

SPEC: http://terjeros.fedorapeople.org/e16/e16.spec
SRPM: http://terjeros.fedorapeople.org/e16/e16-0.16.8.9-2.fc7.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.