[Bug 230161] Review Request: rt61pci-firmware - Firmware for Ralink® RT2561/RT2661 A/B/G network adaptors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rt61pci-firmware - Firmware for Ralink® RT2561/RT2661 A/B/G network adaptors


https://bugzilla.redhat.com/show_bug.cgi?id=230161


notting at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |notting at redhat.com
               Flag|                            |fedora-review+




------- Additional Comments From notting at redhat.com  2007-09-18 00:15 EST -------
MUST items:
 - Package meets naming and packaging guidelines - OK
 - Spec file matches base package name - OK
 - Spec has consistant macro usage. - OK
 - Meets Packaging Guidelines. - OK
 - License - OK
 - License field in spec matches - OK
 - License file included in package - OK
 - Spec in American English - OK
 - Spec is legible. - OK
 - Sources match upstream md5sum:  - OK

 - Package needs ExcludeArch - OK
 - BuildRequires correct - OK
 - Spec handles locales/find_lang - N/A
 - Package is relocatable and has a reason to be. - N/A
 - Package has %defattr and permissions on files is good.  - OK
 - Package has a correct %clean section. - OK
 - Package has correct buildroot
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - OK
 - Package is code or permissible content. - OK, firmware
 - Doc subpackage needed/used. - N/A
 - Packages %doc files don't affect runtime. - OK

 - Headers/static libs in -devel subpackage. - N/A
 - Spec has needed ldconfig in post and postun - N/A
 - .pc files in -devel subpackage/requires pkgconfig - N/A
 - .so files in -devel subpackage. - N/A
 - -devel package Requires: %{name} = %{version}-%{release} - N/A
 - .la files are removed. - N/A
 - Package is a GUI app and has a .desktop file - N/A

 - Package compiles and builds on at least one arch. - OK
 - Package has no duplicate files in %files. - OK
 - Package doesn't own any directories other packages own. - OK
 - Package owns all the directories it creates.  - OK
 - No rpmlint output. - OK
 - final provides and requires are sane: - OK (none)

SHOULD Items:

 - Should build in mock. - OK
 - Should build on all supported archs - noarch, so.. sure.
 - Should function as described. - no hardware, can't test
 - Should have sane scriptlets. - N/A
 - Should have subpackages require base package with fully versioned depend. - N/A
 - Should have dist tag - not needed. Hopefully won't need to rebuild this.
 - Should package latest version - OK

Works for me. APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.