[Bug 275871] Review Request: aldrin - Modular music sequencer/tracker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: aldrin - Modular music sequencer/tracker


https://bugzilla.redhat.com/show_bug.cgi?id=275871





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-18 12:19 EST -------
For 0.11-2:

* SourceURL
  - Please change source URL accroding to:
    http://fedoraproject.org/wiki/Packaging/SourceURL

* Macros
  - Use macros. /usr should be %_prefix .

* Usage unification
  - Choose if you will use macros for commands as much as
    possible, or you won't use macros for commands.
    For example, you use %__mv for mv, while you don't use
    %__rm .
  - Also, choose %buildroot or $RPM_BUILD_ROOT

* ldconfig
  - Why must this package call ldconfig?

* Docdir
--------------------------------------------------------
[tasaka1 at localhost ~]$ ls -lad /usr/share/doc/aldrin*
drwxr-xr-x 4 root root 4096 2007-09-18 22:04 /usr/share/doc/aldrin
drwxr-xr-x 2 root root 4096 2007-09-18 22:04 /usr/share/doc/aldrin-0.11
--------------------------------------------------------
  - "scons install" installs some files under /usr/share/doc/aldrin,
    while "%doc ChangeLog CREDITS INSTALL LICENCE" will install
    them to /usr/share/doc/aldrin-0.11. Please unify the documents'
    directory.

* Python module dependency
  ! This is always hard work, however please do !!
  - Please check python module dependency for this package.

    EXAMPLE:
      /usr/share/aldrin/patterns.py contains the line:
---------------------------------------------------------
    29  import pango
---------------------------------------------------------
      This means that aldrin should have 
      "Requires: pygtk2".
    i.e. You have to check all "import foo" or
         "from foo import bar" sentence and add to the Requires the
         packages which provides those modules.
         Note that some "import" sentences may be additional
         requirements and may not be needed.

* scripts
  Please check:
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
  - This package installs icons under /usr/share/icons/hicolor
    and GTK icon cache must be updated.
  - The desktop file in this package has MimeType info and 
    desktop database must be updated.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.