[Bug 252010] Review Request: rpmrebuild - A tool to build rpm file from rpm database

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rpmrebuild - A tool to build rpm file from rpm database


https://bugzilla.redhat.com/show_bug.cgi?id=252010





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-19 10:21 EST -------
For 2.1.1-6:

* Source URL
  - Any reason you can't use
    http://downloads.sourceforge.net/rpmrebuild/rpmrebuild-2.1.1.tar.gz ?
    (and use %{name} for rpmrebuild, %{version} for 2.1.1)

* Redundant Requires
  - rpm has "Requires: coreutils" and "Requires: textutils, fileutils"
    is not needed for this package.

* %_libdir vs noarch
  - This package is marked as noarch, however %files list use
    %_libdir, which differs between on 32bit arch and on 64bit arch.

    i.e. While this package is marked as noarch (i.e. rebuilding your srpm
         should create the same bin rpm on any arch), the result of rebuilding
         your srpm will differ when arch changes (or maybe on 64bit arch
         rpmbuild fails). This is not right.

* Requires
  - Check Requires again. For example, /usr/lib/rpmrebuild/rpmrebuild.sh
    contains the lines:
-------------------------------------------------------
   179  function RpmBuild
   180  {
   181          # reconstruction fichier rpm : le src.rpm est inutile
   182          # build rpm file, the src.rpm is not usefull to do
   183          # for rpm 4.1 : use rpmbuild
   184          local BUILDCMD=rpm
   185          [ -x /usr/bin/rpmbuild ] && BUILDCMD=rpmbuild
   186          eval $BUILDCMD $rpm_defines -bb $rpm_verbose $additional
${FIC_SPEC} || {
   187                  Error "package '${PAQUET}' build failed"
   188                  return 1
   189          }
   190          
   191          return 0
   192  }
-------------------------------------------------------
     This means this package (rpmrebuild) should have
     "Requires: rpm-build" (%_bindir/rpmbuild is in rpm-build)

? %postun
  - Just a question: what package owns /etc/popt and what is
    the file for? Maybe /etc/popt is already obsolete?
    (Please consider for FC6+)
  - By the way, use macros. /etc must be %_sysconfdir.
  - While I don't know what %postun does, however the lines:
--------------------------------------------------------
  cp /etc/popt /etc/pot.tmp
  sed -e '/RPMREBUILD START/,/RPMREBUILD END/d' /etc/popt.tmp > /etc/popt
--------------------------------------------------------
    apparently contains a typo.

* Directory ownership issue
  - Please make it sure that all directories created by this
    package are owned by this package.
    For example, %_libdir/rpmbuild is not owned by any package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.