[Bug 226200] Merge Review: nkf

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: nkf


https://bugzilla.redhat.com/show_bug.cgi?id=226200





------- Additional Comments From panemade at gmail.com  2007-09-21 04:30 EST -------
(In reply to comment #9)
> (In reply to comment #7)
> 
> > > * defattr
> > >   - Now we recommend %defattr(-,root,root,-)
> >    I am still unclear on usage of this as I guess some packagers still prefer
> > %defattr(-,root,root) bu tI have seen you always asking packagers to use
> > %defattr(-,root,root,-) but can't find this thing written in 
> > packaging guidelines.
>   - Actually also I cannot see the explicit mention in wiki,
>     however
>     * I was told by some other reviewers to do so
>     * and all the examples under http://fedoraproject.org/wiki/Packaging/
>      (for example, http://fedoraproject.org/wiki/Packaging/Guidelines )
>      uses %defattr(-,root,root,-)
> 
    Yes. I also checked same when I saw your comments asking to use that
%defattr(-,root,root,-). But I guess its better to have it mentioned in Guidelines.
> (In reply to comment #8)
> > Thanks for catching them up. should be ok now with the same URL above.
> - Sorry, however more issues:
> 
> * Perl module BuildRequires
>   - For Perl module BuildRequires, please do not use the name of
>     rpms but write the module name of it like
>     http://fedoraproject.org/wiki/Packaging/Perl
>     i.e. "BuildRequires: perl(ExtUtils::MakeMaker)" is better.
> 
> * Directory ownership issue
>    - %{perl_vendorarch}/auto itself is owned by perl and
>      this package should not own the directory.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.